Skip to content

fix: Do not override ember-modal-dialog components #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

fix: Do not override ember-modal-dialog components #1679

merged 1 commit into from
May 2, 2025
+12 −8

Conversation

MichalBryxi
Copy link
Contributor

@MichalBryxi MichalBryxi commented May 2, 2025 •
edited
Loading

MichalBryxi
MichalBryxi commented May 2, 2025
View reviewed changes
@MichalBryxi
Copy link
Contributor Author

Ready to review @SergeAstapov

@SergeAstapov
Copy link
Collaborator

Thank you @MichalBryxi !

@SergeAstapov SergeAstapov merged commit 1c62d1e into ember-learn:main May 2, 2025
15 checks passed
@MichalBryxi MichalBryxi deleted the mb/429-do-not-collide-with-ember-modal-dialog branch May 2, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeAstapov SergeAstapov SergeAstapov approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ember-cli-addon-docs includes ember-modal-dialog and interferes with documented addon
2 participants
@MichalBryxi @SergeAstapov